Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified typo word Resovler to Resolver #554

Merged
merged 1 commit into from
Nov 26, 2020
Merged

modified typo word Resovler to Resolver #554

merged 1 commit into from
Nov 26, 2020

Conversation

lampnick
Copy link
Contributor

@lampnick lampnick commented Nov 11, 2020 •
edited
Loading

What is the purpose of the change

modified typo word Resovler to Resolver

Brief changelog

modified typo word Resovler to Resolver

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

codecov-io commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #554 (3c9ef94) into master (09c1624) will decrease coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   24.81%   24.21%   -0.61%     
==========================================
  Files          49       48       -1     
  Lines        5738     5010     -728     
==========================================
- Hits         1424     1213     -211     
+ Misses       4111     3598     -513     
+ Partials      203      199       -4
Impacted Files Coverage Δ
consumer/option.go 28.33% <ø> (+3.03%) ⬆️
producer/option.go 38.46% <ø> (+3.27%) ⬆️
internal/utils/net.go 40.00% <0.00%> (-7.37%) ⬇️
consumer/lock.go 33.33% <0.00%> (-6.67%) ⬇️
internal/remote/tcp_conn.go 60.00% <0.00%> (-6.67%) ⬇️
internal/model.go 43.37% <0.00%> (-3.37%) ⬇️
internal/remote/codec.go 57.14% <0.00%> (-2.94%) ⬇️
producer/selector.go 71.05% <0.00%> (-2.87%) ⬇️
consumer/strategy.go 72.72% <0.00%> (-2.64%) ⬇️
primitive/base.go 37.50% <0.00%> (-2.50%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c1624...3c9ef94. Read the comment docs.

@ShannonDing ShannonDing added the enhancement New feature or request label Nov 23, 2020
@xujianhai666
Copy link
Member

lgtm

@xujianhai666 xujianhai666 merged commit faeac3f into apache:master Nov 26, 2020
@ShannonDing ShannonDing mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonDing ShannonDing ShannonDing approved these changes

@xujianhai666 xujianhai666 Awaiting requested review from xujianhai666

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lampnick @codecov-io @xujianhai666 @ShannonDing